Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): ios sim log change, android emu TZ/cpus, longer mocha timeout #4120

Merged
merged 4 commits into from
Aug 21, 2020

Conversation

mikehardy
Copy link
Collaborator

Description

Another batch - this should get us over 90%?

  • the ios simulator log change before introduced a new flake, trying a different style to get simulator log now
  • android emulator gets 2 cores now (vs 1) and longer mocha timeouts should help there
  • android emulator gets a pinned timezone so it doesn't waffle and do unnecessary work

Related issues

#4058

Release Summary

chore(e2e): ios sim log change, android emu TZ/cpus, longer mocha timeout

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

pre-booting iOS caused a new flake where detox testee never posted ready to proxy
This allows us to just track virtualized environment upgrades passively,
they appear to update Xcode pretty quickly, and Xcode 12 is coming, so
we will just get that automatically now
@mikehardy mikehardy requested a review from Salakar August 21, 2020 17:15
@vercel
Copy link

vercel bot commented Aug 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/ec7j92q12
✅ Preview: https://react-native-firebase-git-fork-mikehardy-e2e-ci-deflake-more.invertase.vercel.app

@mikehardy mikehardy merged commit 39a2f27 into invertase:master Aug 21, 2020
@mikehardy mikehardy deleted the e2e-ci-deflake-more branch December 16, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants