Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app, ios): bump firebase-ios-sdk to 7.1.0 from 7.0.0 #4533

Merged
merged 2 commits into from
Nov 11, 2020

Conversation

mikehardy
Copy link
Collaborator

Description

Hot on the heels of the forward port from firebase-ios-sdk v6 to v7, v7.1.0 is out

passes tests locally

Related issues

forward port that got us to v7 #4471

Release Summary

feat(app, ios): bump firebase-ios-sdk to 7.1.0 from 7.0.0

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Nov 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/llxzrkikg
✅ Preview: https://react-native-firebase-git-tests-update-710.invertase.vercel.app

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Nov 11, 2020
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #4533 (efd8fe3) into master (fc8c4c0) will increase coverage by 3.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4533      +/-   ##
==========================================
+ Coverage   65.56%   69.16%   +3.60%     
==========================================
  Files         109      109              
  Lines        3699     3699              
  Branches      276      276              
==========================================
+ Hits         2425     2558     +133     
+ Misses       1148     1039     -109     
+ Partials      126      102      -24     

@mikehardy mikehardy merged commit a1e90ae into master Nov 11, 2020
@mikehardy mikehardy deleted the tests-update-7.1.0 branch November 11, 2020 14:21
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Nov 11, 2020
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
…4533)

* chore(tests): update firebase-ios-sdk to 7.1.0
    mostly to test if it is working correctly - it is
* feat(app, ios): bump firebase-ios-sdk to 7.1.0 from 7.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant