feat(auth, emulator): implement useEmulator with jest + e2e testing #4552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/kok0ug41t |
Codecov Report
@@ Coverage Diff @@
## master #4552 +/- ##
==========================================
+ Coverage 69.10% 77.15% +8.05%
==========================================
Files 109 109
Lines 3699 3710 +11
Branches 276 346 +70
==========================================
+ Hits 2556 2862 +306
+ Misses 1041 747 -294
+ Partials 102 101 -1 |
8 tasks
mikehardy
force-pushed
the
auth-emulator
branch
from
4713832
to
46cba37
Compare
Salakar
reviewed
Nov 16, 2020
Salakar
reviewed
Nov 16, 2020
Salakar
reviewed
Nov 16, 2020
Salakar
previously approved these changes
Nov 16, 2020
8 tasks
mikehardy
force-pushed
the
auth-emulator
branch
from
46cba37
to
e1a91c6
Compare
BREAKING CHANGE: switch to setScreenView, logPurchase, logViewPromotion, logRefund as needed
Native implementation is not complete in this commit, but that is next
This is related to a #4487 - attempting to re-login with credential after anonymous user signs in with apple sign-in on android
…n CI This was flaky because the app startup time is so slow it frequently times out the test Runs fine locally
Found at least 2 unexpected real issues in RNFB along the way Found at least 3 Firebase internal errors marked with FIXME that need upstream logging Auth emulator is great, no API limits and now we can cover phone auth and email verify/signin flow in testing
mikehardy
force-pushed
the
auth-emulator
branch
from
e1a91c6
to
4c68841
Compare
mikehardy
pushed a commit
that referenced
this pull request
Sep 4, 2021
…om anon user (matches iOS) (#5694) Description When doing "linkWithCredential" in Android and the users exists relogin with this new user instead of launch exception Error: [auth/credential-already-in-use] This credential is already associated with a different user account. Related PR #4487 and PR #4552
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement
firebase.auth().useEmulatorI'm about to release a major version anyway so I included the removal of deprecated analytics methods
I intend to rebase on to master so these will stay as separate commits and will be picked up correctly for release
It should be reviewed commit by commit for clarity
Phone flow and Email OOB code verification via new emulator APIs is implemented, increasing general test cover vs prior state
Related issues
#4461
#4463
#4510
#4551
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
This enabled me to turn on auth e2e testing again, and I implemented jest tests even though they were really difficult because of the native mocking need
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter