fix(app): convert NativeFirebaseError.getStackWithMessage to static to fix crash #4619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/4x0iv2b39 |
8 tasks
Codecov Report
@@ Coverage Diff @@
## master #4619 +/- ##
=======================================
Coverage 36.61% 36.61%
=======================================
Files 48 48
Lines 1448 1448
Branches 347 347
=======================================
Hits 530 530
Misses 697 697
Partials 221 221 |
androidIsForVivek
pushed a commit
to androidIsForVivek/react-native-firebase
that referenced
this pull request
Aug 9, 2021
…o fix crash (invertase#4619) * change instance method to static method to avoid fatal error while parsing error * http error * lint errors Co-authored-by: blashadow <blackzerogamer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased carry-over from an existing PR by @BlaShadow, all information is contained there:
#3751
It has passed local testing on my machine after being rebased to tip of current master