Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): correct path to source code #4659

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Conversation

antoinewg
Copy link
Contributor

@antoinewg antoinewg commented Dec 8, 2020

Description

The links on the "Edit Page" or "Jump to code" are broken. See this page for instance.

It was working previous to this PR, according to the Vercel preview, although I couldn't figure out what broke it.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

🔥

@vercel
Copy link

vercel bot commented Dec 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/6klu56eow
✅ Preview: https://react-native-firebase-git-master.invertase.vercel.app

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2020

CLA assistant check
All committers have signed the CLA.

@antoinewg antoinewg closed this Dec 8, 2020
@antoinewg antoinewg reopened this Dec 8, 2020
Comment on lines -168 to +170
case 'ml':
return 'ML';
case 'perf':
case 'ml':
return 'ML';
case 'perf':
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am certain that was my whitespace error, sorry for leaving it + thank you for fixing it!

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's clearly broken now and it clearly works in the preview, clean fix, thanks for helping resist entropy, I appreciate it

@mikehardy mikehardy merged commit b535757 into invertase:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants