Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage, ios): resolve listAll promise once and only once on error #4688

Merged
merged 3 commits into from
Dec 18, 2020
Merged

fix(storage, ios): resolve listAll promise once and only once on error #4688

merged 3 commits into from
Dec 18, 2020

Commits on Dec 18, 2020

  1. FIX: [Storage] Don't try resolving the promise twice if an error occu… 

    …rs in listAll()

See https://github.com/firebase/firebase-ios-sdk/blob/14764b8d60a6ad023d8fa5b7f81d42378d92e6fe/FirebaseStorage/Sources/FIRStorageReference.m#L417
    @TPXP @greenbull-tpathier
    TPXP authored and greenbull-tpathier committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    b1ae0dc View commit details
    Browse the repository at this point in the history

  2. TST: Make sure listAll behaves as expected when the user is not autho… 

    …rized
    @TPXP @greenbull-tpathier
    TPXP authored and greenbull-tpathier committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    dcb7ace View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review

    @mikehardy
    mikehardy authored Dec 18, 2020
    Configuration menu
    Copy the full SHA
    6913a61 View commit details
    Browse the repository at this point in the history