-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(analytics): add support for analytics_auto_collection_enabled in firebase.json #4730
feat(analytics): add support for analytics_auto_collection_enabled in firebase.json #4730
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/7p43ydv0o |
Codecov Report
@@ Coverage Diff @@
## master #4730 +/- ##
==========================================
+ Coverage 85.43% 89.09% +3.67%
==========================================
Files 109 109
Lines 3712 3712
Branches 347 347
==========================================
+ Hits 3171 3307 +136
+ Misses 475 363 -112
+ Partials 66 42 -24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks perfect! I compared it to the messaging implementation and yes it looks exactly the same
Can you verify you checked the AndroidManifest.xml and the ios plist and it rendered into them correctly? Seems like it should but nothing beats knowing that you checked
Fantastic, and it looked squeaky clean so I'm not surprised it worked :-) |
Thanks @mikehardy and Happy New Year! 🎉 |
@gewfy likewise! v10.4.0 should be out now with the changes - holler if it doesn't work :-) |
Description
This adds support for the documented but not implemented
analytics_auto_collection_enabled
infirabase.json
.I've aligned this with how
messaging_auto_init_enabled
is implemented.Related issues
Fixes #4473
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
I've asserted that both platforms log that analytics collection gets disabled:
[Firebase/Analytics][I-ACS023013] Analytics collection disabled
FA
Event not sent since app measurement is disabled
🔥 Thanks for all the hard work you've put into these great and very valuable packages!