Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(expo-plugins): leave plugin source/tsconfig in published package #5795

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

mikehardy
Copy link
Collaborator

This way users may rebuild it from source if the need to for some reason

Related issues

Noticed this when a community member wanted to add expo config plugin code to Notifee, based on react-native-firebase and it turns out we weren't shipping the source here invertase/notifee#190

Release Summary

Conventional commit, should not actually generate a release on it's own but next release will have source

Test Plan

  • Verify locally via yarn pack in packages/app that this has the desired effect:

mike@osxvm:~/work/Invertase/react-native-firebase/packages/app (@mikehardy/include-expo-plugin-source) % tar -ztvf react-native-firebase-app-v12.9.1.tgz |grep plugin
-rw-r--r--  0 0      0          44 Aug  2 18:30 package/app.plugin.js
drwxr-xr-x  0 0      0           0 Oct 15 12:02 package/plugin
drwxr-xr-x  0 0      0           0 Oct 15 12:02 package/plugin/build
drwxr-xr-x  0 0      0           0 Aug  2 18:30 package/plugin/src
-rw-r--r--  0 0      0         171 Aug  2 18:30 package/plugin/tsconfig.json
drwxr-xr-x  0 0      0           0 Oct 15 12:02 package/plugin/build/android
-rw-r--r--  0 0      0         122 Oct 15 12:02 package/plugin/build/index.d.ts
-rw-r--r--  0 0      0         807 Oct 15 12:02 package/plugin/build/index.js
drwxr-xr-x  0 0      0           0 Oct 15 12:02 package/plugin/build/ios
drwxr-xr-x  0 0      0           0 Aug 11 11:57 package/plugin/src/android
-rw-r--r--  0 0      0         784 Aug  2 18:30 package/plugin/src/index.ts
drwxr-xr-x  0 0      0           0 Aug 13 11:39 package/plugin/src/ios
-rw-r--r--  0 0      0         260 Oct 15 12:02 package/plugin/build/android/applyPlugin.d.ts
-rw-r--r--  0 0      0        1286 Oct 15 12:02 package/plugin/build/android/applyPlugin.js
-rw-r--r--  0 0      0         289 Oct 15 12:02 package/plugin/build/android/buildscriptDependency.d.ts
-rw-r--r--  0 0      0        1383 Oct 15 12:02 package/plugin/build/android/buildscriptDependency.js
-rw-r--r--  0 0      0         279 Oct 15 12:02 package/plugin/build/android/constants.d.ts
-rw-r--r--  0 0      0         570 Oct 15 12:02 package/plugin/build/android/constants.js
-rw-r--r--  0 0      0         158 Oct 15 12:02 package/plugin/build/android/copyGoogleServices.d.ts
-rw-r--r--  0 0      0        1610 Oct 15 12:02 package/plugin/build/android/copyGoogleServices.js
-rw-r--r--  0 0      0         302 Oct 15 12:02 package/plugin/build/android/index.d.ts
-rw-r--r--  0 0      0         871 Oct 15 12:02 package/plugin/build/android/index.js
-rw-r--r--  0 0      0         186 Oct 15 12:02 package/plugin/build/ios/appDelegate.d.ts
-rw-r--r--  0 0      0        1939 Oct 15 12:02 package/plugin/build/ios/appDelegate.js
-rw-r--r--  0 0      0         350 Oct 15 12:02 package/plugin/build/ios/googleServicesPlist.d.ts
-rw-r--r--  0 0      0        2235 Oct 15 12:02 package/plugin/build/ios/googleServicesPlist.js
-rw-r--r--  0 0      0         187 Oct 15 12:02 package/plugin/build/ios/index.d.ts
-rw-r--r--  0 0      0         577 Oct 15 12:02 package/plugin/build/ios/index.js
-rw-r--r--  0 0      0        1023 Aug  2 18:30 package/plugin/src/android/applyPlugin.ts
-rw-r--r--  0 0      0        1121 Aug  2 18:30 package/plugin/src/android/buildscriptDependency.ts
-rw-r--r--  0 0      0         380 Aug  2 18:30 package/plugin/src/android/constants.ts
-rw-r--r--  0 0      0        1105 Aug 11 11:57 package/plugin/src/android/copyGoogleServices.ts
-rw-r--r--  0 0      0         303 Aug  2 18:30 package/plugin/src/android/index.ts
-rw-r--r--  0 0      0        1463 Aug 13 11:39 package/plugin/src/ios/appDelegate.ts
-rw-r--r--  0 0      0        1728 Aug  2 18:30 package/plugin/src/ios/googleServicesPlist.ts
-rw-r--r--  0 0      0         188 Aug  2 18:30 package/plugin/src/ios/index.ts
  • Check package contents of app/crashlytics/perf after NPM download and see if they have it

Think react-native-firebase is great? Please consider supporting the project with any of the below:

This way users may rebuild it from source if the need to for some reason
@vercel
Copy link

vercel bot commented Oct 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/9gJdjZUCg7YD3CgjQnyo2TTSt4xz
✅ Preview: https://react-native-firebase-git-mikehardy-include-ex-7afbf7-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/2nR15XpVacLUgbRymEmUSAyXEvLg
✅ Preview: Canceled

@mikehardy
Copy link
Collaborator Author

@barthap this ☝️ seems like a simple change - just to include plugin source in npm package - what do you think? I think it's nice to have, as a consumer

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #5795 (aaefc2e) into master (aabb075) will decrease coverage by 28.98%.
The diff coverage is n/a.

❗ Current head aaefc2e differs from pull request most recent head dd365a3. Consider uploading reports for the commit dd365a3 to get more accurate results

@@              Coverage Diff              @@
##             master    #5795       +/-   ##
=============================================
- Coverage     53.17%   24.19%   -28.97%     
=============================================
  Files           208       95      -113     
  Lines         10069     4073     -5996     
  Branches       1542      956      -586     
=============================================
- Hits           5353      985     -4368     
+ Misses         4459     2491     -1968     
- Partials        257      597      +340     

Copy link
Contributor

@barthap barthap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - it's like a partial revert of #5565 😉

I agree that source may sometimes be useful.

@mikehardy
Copy link
Collaborator Author

Great, thanks for checking it. I don't know why I didn't think of it when #5565 went through - I'm usually super pro-source and must have just missed it :)

@mikehardy mikehardy merged commit 9c66f37 into master Oct 15, 2021
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Oct 15, 2021
@mikehardy mikehardy deleted the @mikehardy/include-expo-plugin-source branch October 17, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants