Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth, types): verifyPasswordResetCode returns Promise<string> with email address #6537

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

ShaneZhengNZ
Copy link
Contributor

Function verifyPasswordResetCode does return the email address string if valid, therefore, update the TypeScript definition to match.

Description

verifyPasswordResetCode does return string result, without the correct typing, we are forced to ignore the linting warning.

Related issues

n/a

Release Summary

n/a

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Sep 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview Sep 15, 2022 at 3:09AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Sep 15, 2022 at 3:09AM (UTC)

That function does return the email address string if valid, therefore, update the TypeScript definition to match.
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #6537 (08b528b) into main (dc74643) will decrease coverage by 0.40%.
The diff coverage is 100.00%.

❗ Current head 08b528b differs from pull request most recent head 1b8c655. Consider uploading reports for the commit 1b8c655 to get more accurate results

@@             Coverage Diff              @@
##               main    #6537      +/-   ##
============================================
- Coverage     54.90%   54.50%   -0.39%     
+ Complexity      689      679      -10     
============================================
  Files           208      208              
  Lines         10358    10358              
  Branches       1645     1645              
============================================
- Hits           5686     5645      -41     
- Misses         4371     4432      +61     
+ Partials        301      281      -20     

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikehardy mikehardy changed the title fix(auth): update verifyPasswordResetCode TypeScript definition fix(auth, types): update verifyPasswordResetCode TypeScript definition Sep 17, 2022
@mikehardy mikehardy changed the title fix(auth, types): update verifyPasswordResetCode TypeScript definition fix(auth, types): verifyPasswordResetCode returns Promise<string> with email address Sep 17, 2022
@mikehardy mikehardy merged commit 6f67c2c into invertase:main Sep 17, 2022
@ShaneZhengNZ ShaneZhengNZ deleted the patch-2 branch September 18, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants