Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(functions): Expose modular API that matches the Firebase web JS SDK v9 API #6764

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Dec 6, 2022

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 6, 2022 at 3:17PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Dec 6, 2022 at 3:17PM (UTC)

@russellwheatley russellwheatley changed the title Expose modular functions API feat(functions): Expose modular API that matches the Firebase web JS SDK v9 API Dec 6, 2022
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

This looks like what I expect based on previous app modular implementation.

@Lyokone, what do you think?

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #6764 (19f6ccf) into main (254e7ad) will decrease coverage by 20.97%.
The diff coverage is 50.00%.

@@              Coverage Diff              @@
##               main    #6764       +/-   ##
=============================================
- Coverage     54.03%   33.07%   -20.96%     
=============================================
  Files           217      218        +1     
  Lines         10790    10798        +8     
  Branches       1699     1699               
=============================================
- Hits           5829     3570     -2259     
- Misses         4668     7148     +2480     
+ Partials        293       80      -213     

@russellwheatley russellwheatley marked this pull request as ready for review December 6, 2022 16:43
@Lyokone
Copy link
Contributor

Lyokone commented Dec 7, 2022

@mikehardy It is what I expect too :)

@russellwheatley russellwheatley merged commit 0b0b2e5 into main Dec 7, 2022
@russellwheatley russellwheatley deleted the feat/modular-functions branch December 7, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants