Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remote-config): incorrect if condition statement & inline documentation update #6892

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Feb 7, 2023

Description

I fixed the docs and noticed that one of the conditions was incorrect so I updated that as well 😓.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Feb 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 3:36PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Feb 7, 2023 at 3:36PM (UTC)

@russellwheatley russellwheatley changed the title fix: incorrect if condition & doc update fix(remote-config): incorrect if condition statement & inline documentation update Feb 7, 2023
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was curious about that inverted conditional but let it slip by me as well, alas to be human

@mikehardy mikehardy merged commit 1a1488c into main Feb 7, 2023
@mikehardy mikehardy deleted the remote-config-update branch February 7, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants