Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-check): Expose modular API that matches the Firebase web JS SDK v9 API #6912

Merged
merged 5 commits into from
Feb 15, 2023

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Feb 15, 2023

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Feb 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 15, 2023 at 9:44AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Feb 15, 2023 at 9:44AM (UTC)

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #6912 (022f9a3) into main (5766667) will decrease coverage by 0.01%.
The diff coverage is 41.67%.

@@             Coverage Diff              @@
##               main    #6912      +/-   ##
============================================
- Coverage     54.39%   54.38%   -0.01%     
  Complexity      718      718              
============================================
  Files           226      227       +1     
  Lines         11181    11193      +12     
  Branches       1767     1768       +1     
============================================
+ Hits           6081     6086       +5     
- Misses         4767     4774       +7     
  Partials        333      333              

@Lyokone Lyokone marked this pull request as ready for review February 15, 2023 11:43
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - as mentioned the v9 API was already in place as a function but now it is happily modularly exposed, thank you!

@mikehardy mikehardy merged commit bf02676 into main Feb 15, 2023
@mikehardy mikehardy deleted the feat/app-check-modular branch February 15, 2023 18:43
exaby73 pushed a commit that referenced this pull request Aug 8, 2023
@apetta
Copy link
Contributor

apetta commented Oct 4, 2023

+1 for replay protection support by exposing relevant functions for getting single use app check tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants