Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(multi-factor-auth): fix typo #7156

Closed
wants to merge 1 commit into from

Conversation

katayama8000
Copy link

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2023 4:42pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
react-native-firebase-next ⬜️ Ignored (Inspect) Jun 2, 2023 4:42pm

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@katayama8000 katayama8000 changed the title docs(multi-factor-auth):fix typo docs(multi-factor-auth): fix typo Jun 2, 2023
mikehardy added a commit that referenced this pull request Jun 5, 2023
@mikehardy
Copy link
Collaborator

Thank you very much for catching this! It's missing the CLA signing and for a change this small + obviously correct it's easier to just reimplement quickly and push it through myself so I get the change in quickly while I have time - I'm going to merge #7164 with the same change supercedingthis one. Cheers!

@mikehardy mikehardy closed this Jun 5, 2023
mikehardy added a commit that referenced this pull request Jun 5, 2023
exaby73 pushed a commit that referenced this pull request Jul 25, 2023
exaby73 pushed a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants