Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to sdk v9 (ios), upgrade to sdk 20.6.0 (android) #115

Merged
merged 3 commits into from
Apr 19, 2022
Merged

feat: migrate to sdk v9 (ios), upgrade to sdk 20.6.0 (android) #115

merged 3 commits into from
Apr 19, 2022

Conversation

dylancom
Copy link
Collaborator

@dylancom dylancom commented Apr 19, 2022 •
edited by mikehardy
Loading

Description

Fixes #113 / Fixes #114

Major upgrade to 9.3.0 on iOS. (See: https://developers.google.com/admob/ios/migration)

  • Rename adDidPresentFullScreenContent: to adWillPresentFullScreenContent:
    There is no behavior change. The delegate method is invoked right before the ad is about to be presented, so the new method name better reflects its functionality.

  • Remove location setting API on GADRequest
    (void)setLocationWithLatitude:longitude:accuracy: has been deleted from GADRequest since location data is not used by Google to target ads. Use third-party APIs to provide the information to third-party ad networks if required.

Minor upgrade from 20.5.0 to 20.6.0 on Android.

@dylancom dylancom force-pushed the feature/upgrade-google-mobile-ads-sdk branch from 088b91c to 5adcf90 Compare April 19, 2022 14:21
@codecov
Copy link

codecov bot commented Apr 19, 2022 •
edited
Loading

Codecov Report

Merging #115 (080ef16) into main (d03f45a) will increase coverage by 0.55%.
The diff coverage is n/a.

❗ Current head 080ef16 differs from pull request most recent head c3c74ad. Consider uploading reports for the commit c3c74ad to get more accurate results

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   19.71%   20.25%   +0.55%     
==========================================
  Files          29       29              
  Lines         746      726      -20     
  Branches      190      181       -9     
==========================================
  Hits          147      147              
+ Misses        599      579      -20

@dylancom dylancom requested a review from mikehardy April 19, 2022 15:09
mikehardy added a commit that referenced this pull request Apr 19, 2022
@mikehardy
feat(android, sdk): update to google mobile ads sdk 20.6.0
486fea7 
Note that in combination with #115 this fixes #114 - the location
change was the only breaking change between v20 and proposed v21 of android SDK
@mikehardy mikehardy force-pushed the feature/upgrade-google-mobile-ads-sdk branch from 5adcf90 to 945d1b5 Compare April 19, 2022 20:08
dylancom and others added 3 commits April 19, 2022 15:20
@dylancom @mikehardy
feat(ios, sdk): migrate to mobile ads sdk v9
9456bb4 
Fixes #113

BREAKING CHANGES: The update to google mobile ads ios SDK v9 has these changes -

iOS 10 will no longer receive ads, iOS 11 is the minimum version to receive ads
Location ad request options are ignored, locations are not used for ads in the SDK
@mikehardy
feat(android, sdk): update to google mobile ads sdk 20.6.0
13e3dfe 
Note that in combination with #115 this fixes #114 - the location
change was the only breaking change between v20 and proposed v21 of android SDK
@mikehardy
chore(example): result of refresh-example script run w/new SDKs
c3c74ad 
minor tweak - remove more of the ruby bundler gemfile version cruft
@mikehardy mikehardy force-pushed the feature/upgrade-google-mobile-ads-sdk branch from 945d1b5 to c3c74ad Compare April 19, 2022 20:27
@mikehardy
Copy link
Collaborator

Screwed up my first attempt to chunk these up into separate units, but I think I got it correct the second time.
This is great - really not much, as you said, to adapt. in fact by my read the Android one is already going to work without additional changes now that the location stuff is gone, to do iOS v9

Mostly the commit adds the breaking change notice that I want for the merge, I will wait to release it until we are done with the listener + GAM break and get one v6 out with all of them

mikehardy
mikehardy approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a thing of beauty

@mikehardy mikehardy added the workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready label Apr 19, 2022
@mikehardy mikehardy merged commit 8e6fd48 into main Apr 19, 2022
mikehardy added a commit that referenced this pull request Apr 19, 2022
@mikehardy
feat(android, sdk): update to google mobile ads sdk 20.6.0
26ef269 
Note that in combination with #115 this fixes #114 - the location
change was the only breaking change between v20 and proposed v21 of android SDK
@mikehardy mikehardy deleted the feature/upgrade-google-mobile-ads-sdk branch April 19, 2022 21:33
@mikehardy mikehardy removed the workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready label Apr 19, 2022
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to v21 APIs for Google Mobile Ads Android SDK Update to v9 of Google Ads iOS SDK
2 participants
@dylancom @mikehardy