-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Ad Inspector #116
Conversation
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
==========================================
- Coverage 22.83% 22.77% -0.06%
==========================================
Files 29 29
Lines 758 760 +2
Branches 183 183
==========================================
Hits 173 173
- Misses 585 587 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really neat! Might be worth a mention in the README?
And one thing to change about the example, but it's easy - this all looks great
The iOS CI fail was something unrelated, I restarted it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic! I pulled it locally and ran it, easy to run in the example and the results are great. I think this will really help people, thanks for implementing it!
## [6.0.0](v5.1.1...v6.0.0) (2022-04-27) ### ⚠ BREAKING CHANGES * add addAdEventListener method (#110) ### Features * add Ad Inspector ([#116](#116)) ([dd36436](dd36436)) * add addAdEventListener method ([#110](#110)) ([e842477](e842477)) * Add Google Ad Manager support ([#105](#105)) ([48f77da](48f77da)) * **android, sdk:** update to google mobile ads sdk 20.6.0 ([26ef269](26ef269)), closes [#114](#114) * **ios, sdk:** migrate to mobile ads sdk v9 ([36a440a](36a440a)), closes [#113](#113) ### Bug Fixes * fix wrong hook return type omit ([8bbc0ad](8bbc0ad))
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [6.0.0](invertase/react-native-google-mobile-ads@v5.1.1...v6.0.0) (2022-04-27) ### ⚠ BREAKING CHANGES * add addAdEventListener method (#110) ### Features * add Ad Inspector ([#116](invertase/react-native-google-mobile-ads#116)) ([dd36436](invertase/react-native-google-mobile-ads@dd36436)) * add addAdEventListener method ([#110](invertase/react-native-google-mobile-ads#110)) ([e842477](invertase/react-native-google-mobile-ads@e842477)) * Add Google Ad Manager support ([#105](invertase/react-native-google-mobile-ads#105)) ([48f77da](invertase/react-native-google-mobile-ads@48f77da)) * **android, sdk:** update to google mobile ads sdk 20.6.0 ([26ef269](invertase/react-native-google-mobile-ads@26ef269)), closes [#114](invertase/react-native-google-mobile-ads#114) * **ios, sdk:** migrate to mobile ads sdk v9 ([36a440a](invertase/react-native-google-mobile-ads@36a440a)), closes [#113](invertase/react-native-google-mobile-ads#113) ### Bug Fixes * fix wrong hook return type omit ([8bbc0ad](invertase/react-native-google-mobile-ads@8bbc0ad))
Description
This PR adds Ad Inspector functionality.
Related issues
Release Summary
Added AdInspector Module
Checklist
and followed the process outlined there for submitting PRs.
Android
iOS
e2e
tests added or updated in__tests__e2e__
jest
tests added or updated in__tests__
Test Plan
Updated example app.
Think
react-native-google-mobile-ads
is great? Please consider supporting the project with any of the below:Invertase
on Twitter