Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Ad Inspector #116

Merged
merged 8 commits into from
Apr 26, 2022
Merged

feat: add Ad Inspector #116

merged 8 commits into from
Apr 26, 2022

Conversation

wjaykim
Copy link
Collaborator

@wjaykim wjaykim commented Apr 21, 2022

Description

This PR adds Ad Inspector functionality.

Related issues

Release Summary

Added AdInspector Module

Checklist

  • I read the Contributor Guide
    and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in __tests__e2e__
    • jest tests added or updated in __tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Updated example app.


Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

  • 👉 Star this repo on GitHub ⭐️
  • 👉 Follow Invertase on Twitter

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #116 (f230e59) into main (e842477) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

❗ Current head f230e59 differs from pull request most recent head 8a0129a. Consider uploading reports for the commit 8a0129a to get more accurate results

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   22.83%   22.77%   -0.06%     
==========================================
  Files          29       29              
  Lines         758      760       +2     
  Branches      183      183              
==========================================
  Hits          173      173              
- Misses        585      587       +2     

@wjaykim wjaykim marked this pull request as draft April 21, 2022 15:16
@wjaykim wjaykim changed the title feat: add AdInspector module feat: add Ad Inspector Apr 21, 2022
@wjaykim wjaykim marked this pull request as ready for review April 21, 2022 15:24
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really neat! Might be worth a mention in the README?
And one thing to change about the example, but it's easy - this all looks great
The iOS CI fail was something unrelated, I restarted it

example/src/AdInspector.tsx Outdated Show resolved Hide resolved
@mikehardy mikehardy added workflow: waiting for feedback Waiting on response to questions workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready labels Apr 21, 2022
@wjaykim wjaykim requested a review from mikehardy April 23, 2022 07:48
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! I pulled it locally and ran it, easy to run in the example and the results are great. I think this will really help people, thanks for implementing it!

@mikehardy mikehardy removed workflow: waiting for feedback Waiting on response to questions workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready labels Apr 26, 2022
@mikehardy mikehardy merged commit dd36436 into invertase:main Apr 26, 2022
@wjaykim wjaykim deleted the ad-inspector branch April 26, 2022 06:28
github-actions bot pushed a commit that referenced this pull request Apr 27, 2022
## [6.0.0](v5.1.1...v6.0.0) (2022-04-27)

### ⚠ BREAKING CHANGES

* add addAdEventListener method (#110)

### Features

* add Ad Inspector ([#116](#116)) ([dd36436](dd36436))
* add addAdEventListener method ([#110](#110)) ([e842477](e842477))
* Add Google Ad Manager support ([#105](#105)) ([48f77da](48f77da))
* **android, sdk:** update to google mobile ads sdk 20.6.0 ([26ef269](26ef269)), closes [#114](#114)
* **ios, sdk:** migrate to mobile ads sdk v9 ([36a440a](36a440a)), closes [#113](#113)

### Bug Fixes

* fix wrong hook return type omit ([8bbc0ad](8bbc0ad))
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Star-dev325 pushed a commit to Star-dev325/react-native-google-mobile-ads that referenced this pull request Jun 7, 2024
## [6.0.0](invertase/react-native-google-mobile-ads@v5.1.1...v6.0.0) (2022-04-27)

### ⚠ BREAKING CHANGES

* add addAdEventListener method (#110)

### Features

* add Ad Inspector ([#116](invertase/react-native-google-mobile-ads#116)) ([dd36436](invertase/react-native-google-mobile-ads@dd36436))
* add addAdEventListener method ([#110](invertase/react-native-google-mobile-ads#110)) ([e842477](invertase/react-native-google-mobile-ads@e842477))
* Add Google Ad Manager support ([#105](invertase/react-native-google-mobile-ads#105)) ([48f77da](invertase/react-native-google-mobile-ads@48f77da))
* **android, sdk:** update to google mobile ads sdk 20.6.0 ([26ef269](invertase/react-native-google-mobile-ads@26ef269)), closes [#114](invertase/react-native-google-mobile-ads#114)
* **ios, sdk:** migrate to mobile ads sdk v9 ([36a440a](invertase/react-native-google-mobile-ads@36a440a)), closes [#113](invertase/react-native-google-mobile-ads#113)

### Bug Fixes

* fix wrong hook return type omit ([8bbc0ad](invertase/react-native-google-mobile-ads@8bbc0ad))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants