feat: inline adaptive banner with custom width #296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #296 +/- ##
=======================================
Coverage 33.51% 33.51%
=======================================
Files 33 33
Lines 797 797
Branches 198 198
=======================================
Hits 267 267
Misses 530 530 |
1 task
dylancom
force-pushed
the
feature/custom-width-adaptive-height
branch
2 times, most recently
from
cda1754 to
c0db2f8
Compare
8 tasks
dylancom
force-pushed
the
feature/custom-width-adaptive-height
branch
from
73246c4 to
1ec68a3
Compare
dylancom
force-pushed
the
feature/custom-width-adaptive-height
branch
from
0a7d4ef to
f44a15e
Compare
|
hello, |
|
Wasn't so happy about this solution. Ideally it should take the width of the surrounding View. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently an adaptive banner always takes the screen width (with taking into account safe areas).
There are multiple users that would like to use a custom width and seem to fall back to trying out "FLUID" sizing?
Currently you can define a custom size "300x200" to get a custom sized ad. This PR makes it possible get an ad with custom width + adaptive height.
Usage
<Banner size="300x" unitId="***" /><Banner size={`${SCREEN_WIDTH - MARGIN}x`} unitId="***" />