-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve AndroidManifest conflict for AD_SERVICES_CONFIG #660
fix: resolve AndroidManifest conflict for AD_SERVICES_CONFIG #660
Conversation
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~660 Documentation is deployed and generated using docs.page. |
Hey @lottemarines thank you! Can you follow the details link on the CLA Bot's comment and sign the CLA? CI is running now and if Android builds and runs successfully this should be good to go |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
==========================================
- Coverage 43.72% 42.79% -0.93%
==========================================
Files 30 30
Lines 549 575 +26
Branches 151 155 +4
==========================================
+ Hits 240 246 +6
- Misses 309 329 +20
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not able to commit on your fork+branch, so I left a suggestion - just an XML comment
Then it's good to go, verified works
Co-authored-by: Mike Hardy <github@mikehardy.net>
@mikehardy I have added the suggested XML comment. Thank you for the suggestion! |
### [14.4.2](v14.4.1...v14.4.2) (2024-11-24) ### Bug Fixes * resolve AndroidManifest conflict for AD_SERVICES_CONFIG ([#660](#660)) ([831bb8f](831bb8f))
🎉 This PR is included in version 14.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR resolves a conflict in AndroidManifest.xml for the property android.adservices.AD_SERVICES_CONFIG. The issue occurs when both react-native-google-mobile-ads (via play-services-ads-lite) and @react-native-firebase/analytics (via play-services-measurement-api) declare the same property, causing a build failure.
By adding tools:replace="android:resource" to the element in the react-native-google-mobile-ads manifest, this library takes precedence, resolving the conflict and allowing the project to build successfully.
Related issues
Fixes #657
Release Summary
Added tools:replace="android:resource" to in AndroidManifest.xml of react-native-google-mobile-ads.
This ensures compatibility when used with libraries like @react-native-firebase/analytics.
Checklist
and followed the process outlined there for submitting PRs.
Android
iOS
e2e
tests added or updated in__tests__e2e__
jest
tests added or updated in__tests__
Test Plan
npx expo run:android
=> BUILD SUCCESSFUL