- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add native ad compatibility layer #687
base: main
Are you sure you want to change the base?
Conversation
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~687 Documentation is deployed and generated using docs.page. |
|
a680f96
to
185ef85
Compare
bf7970e
to
d8cdc87
Compare
any update on getting this merged? |
We've been testing this PR with a patch-package and everything seems to be working well. We're on RN 0.74.5, using the old arch. App built correctly and all events are firing normally. |
Why not upgrade to 0.76 and set old arch true. RN0.78 is already released. |
Description
Removed codegen event emitter(added in RN 0.76.2) related code and replaced it with
GoogleMobileAdsNativeEventEmitter
, which is shared legacy event emitter(which is used in full screen ads).Also I removed unnecessary constructor passing contexts in classes extending ViewGroupManager, which breaks android build in rn version lower than 0.75.
Related issues
Fixes #678
Release Summary
Checklist
and followed the process outlined there for submitting PRs.
Android
iOS
e2e
tests added or updated in__tests__e2e__
jest
tests added or updated in__tests__
Test Plan
Think
react-native-google-mobile-ads
is great? Please consider supporting the project with any of the below:Invertase
on Twitter