Skip to content

Conversation

bozzmob
Copy link
Contributor

@bozzmob bozzmob commented Dec 27, 2015

Drawer menu items now supports Labels - DEMO. In reference to the commit in the lib.

Screenshot-

drawer labels

@Ehesp
Copy link
Member

Ehesp commented Dec 27, 2015

Cheers - once 0.3.0 is out I'll merge. Shouldn't be long.

@bozzmob
Copy link
Contributor Author

bozzmob commented Dec 27, 2015

WOW! Awesome 👍 I am all geared up! :)

@bozzmob
Copy link
Contributor Author

bozzmob commented Jan 2, 2016

Unless we merge this PR, I will not able to create a new PR or checkin for uploading the demo app. :(

@Ehesp
Copy link
Member

Ehesp commented Jan 2, 2016

I might just push up 0.3 as is without the List bit yet (not had chance to do it). Then I can merge in the dev branch of this which has the changes needed.

@bozzmob
Copy link
Contributor Author

bozzmob commented Jan 2, 2016

Yeah! Ok. Carry forward List View task to 0.4 release :)

@bozzmob
Copy link
Contributor Author

bozzmob commented Jan 2, 2016

Let me know when this PR can be merged. I have some commits waiting on my local.

@Ehesp
Copy link
Member

Ehesp commented Jan 2, 2016

Okay are they anything breaking? The dev branch on here has quite a lot of changes (fixes for 0.3 and some other handy things.

@bozzmob
Copy link
Contributor Author

bozzmob commented Jan 2, 2016

Nope. The current PR works fine. And the other commits are not code related for now. They are mostly enhancing the README & Docs. Adding APK etc.,

@bozzmob
Copy link
Contributor Author

bozzmob commented Jan 2, 2016

In parallel I am working on a Gridview component for material design. When it comes to a decent shape, you can verify it. And then, we can push it to this repo. :)

@Ehesp
Copy link
Member

Ehesp commented Jan 2, 2016

Okay I'll sort it out.... Release 0.3, merge over the dev branch of this repo... then you can bring your updates over (will need an APK rebuild though I guess!)

@bozzmob
Copy link
Contributor Author

bozzmob commented Jan 2, 2016

Yes. Will pull the latest changes & rebuild the APK after you complete the merge :)

@Ehesp
Copy link
Member

Ehesp commented Jan 2, 2016

Okay pulled over :)

@bozzmob
Copy link
Contributor Author

bozzmob commented Jan 2, 2016

UPDATE:

I pulled the latest released code. Applied my changes on it & tested it. Its working fine on phone. Will go ahead and merge if that's ok.

Here is the screenshot from the latest build-

merge final commit

bozzmob added a commit that referenced this pull request Jan 2, 2016
Drawer menu items now supports Labels - DEMO
@bozzmob bozzmob merged commit 2c2220d into invertase:master Jan 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants