Refactor of thread management in neuronavigation #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vhosouza
commented
Jun 23, 2020
vhosouza
commented
- Major update on navigation thread management using Queues, Events, and Jobs
- Added affine to the saved project
- Standardized the dialogs for saving and loading files in navigation tab
- Improved array multiplication using the matrix operator
- Added tractography computation tab but still in hidden state by default, needs revision
- Replaced dialog warnings for message box in navigation tab
…in world coordinates
… in flip_x - Additional refactor of FRE computation and use of base_creation
- Improved offset computation for seed - Improved flip_x. No need to use a function, only multiply Y coordinate by -1
…mputation - Cleaned unecessary comments - Providing m_img already flip_x while set_message
…tracker but not tested in real tracker
- Tracts actors are computed all at once, no optimization for computing blocks
- Navgation with tractography running
- Tractography navigation working at 0.1-s sleep
- created thread in new format for trigger - removed comments of unused pipelines and threading - removed commented old FRE base creation
- Navigation with object working seamless with and without tracts - Navigation in other modes (single ref, no object) not working - Added one extra queue to generalize the pipeline in navigation
- Object corregistration split in functions - Cleaned comments on reference computation
- Applied the new threading to the non-object navigations - Improved visualization of the offset marker for tractography - Cleaned commented code
…rm transformation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.