-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup pyproject.toml for Ruff and MyPy configurations #768
Conversation
formatted and type hinted style.py, and presets.py
I remembered that I should add ruff and mypy versions to optional-requirements.txt. I did just that. |
Hi @omar-abdelgawad. I tested here. I'm using Python 3.11. I'm having this error:
If I add Other thing. I think the |
…o avoid runtime errors
Hi @tfmoraes . I apologize for not noticing this runtime error. I read the docs and evaluating annotations at runtime happens only with function parameters which I missed. I tested it now and it works. I also reverted the changes regarding |
Thanks @omar-abdelgawad. Merging it. |
📢 Describe your changes
Changed(removed)tr
variable name🧪 How to test this Pull Request
ruff check invesalius/presets.py invesalius/style.py --extend-select UP --extend-select I
🗒️ Notes for future improvements
I use this PR template a lot and I can make a PR to add to the repo if it is good enough. I believe having a template makes documenting pull requests much easier.
✅Checklist before requesting a review