Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lighthouse result forwarding #663

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Fix lighthouse result forwarding #663

merged 2 commits into from
Apr 8, 2022

Conversation

hgajjar
Copy link

@hgajjar hgajjar commented Feb 4, 2022

There were two issues:

  • It wasn't allowing ws lighthouse --with-results command to pass OUTPUT_RESULTS env var correctly
  • This ws command was executing docker-compose run with TTY, which was causing it to combine stdout and stderr, which was making it impossible to forward the result json output to a file on host machine (eg. ws lighthouse --with-results > result.json

@andytson-inviqa andytson-inviqa force-pushed the bugfix/MISC-fix-lighthouse-result-forwarding branch from 3fd660c to 92f2e3d Compare February 22, 2022 09:06
@andytson-inviqa andytson-inviqa added bug Something isn't working harness-all Changes required to all harness directories labels Apr 1, 2022
@andytson-inviqa andytson-inviqa added this to the 1.3.0 milestone Apr 1, 2022
@andytson-inviqa andytson-inviqa merged commit 1fd4e92 into 1.3.x Apr 8, 2022
@andytson-inviqa andytson-inviqa deleted the bugfix/MISC-fix-lighthouse-result-forwarding branch April 8, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andytson-inviqa andytson-inviqa andytson-inviqa approved these changes

Assignees
No one assigned
Labels
bug Something isn't working harness-all Changes required to all harness directories
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hgajjar @andytson-inviqa