Ignore null template key values #679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgajjar
approved these changes
Apr 21, 2022
andytson-inviqa
requested changes
Apr 28, 2022
| @@ -85,4 +86,5 @@ server { | |||
| fastcgi_param APPLICATION_STORE {{ store_code }}; | |||
| } | |||
| } | |||
| {% endif %} | |||
There was a problem hiding this comment.
misses zed api further down, however there's another PR for that #685
| @@ -3,7 +3,7 @@ | |||
| {% set syncvolume = true %} | |||
| {% endif %} | |||
| {% set hostnames = [@('hostname')] %} | |||
| {% set hostnames = hostnames|merge(@('hostname_aliases')|map(alias => "#{alias}." ~ @('domain'))) %} | |||
| {% set hostnames = hostnames|merge(@('hostname_aliases')| filter(v => v is not empty) | map(alias => "#{alias}." ~ @('domain'))) %} | |||
There was a problem hiding this comment.
Just this bit now that is what we want to keep after @Chemaclass's PRs now merged
There was a problem hiding this comment.
although should also be done for varnish. I'll create a PR
There was a problem hiding this comment.
#689, I've instead done at the source
Chemaclass
reviewed
Apr 28, 2022
Comment on lines
+258
to
+260
| if ($value === null) { | ||
| continue; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for values set to
~that are compiled together using this function, these values are still appended to the output. This ensures that for any null values passed into this function, that they are ignored.