Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getSignalsForGracefulWorkerShutdown() to QueueConfig #682

Conversation

Chemaclass
Copy link
Contributor

📖 Description

The harness is already doing an override (getQueueProcessTimeout()) to add the process timeout to fix issues with queues not completing during app install. The method getSignalsForGracefulWorkerShutdown() was introduced in Spryker 2021.08, but it's not in the workspace harness yet.

@kierenevans kierenevans added enhancement New feature or request harness-spryker Spryker harness labels Apr 27, 2022
@kierenevans kierenevans enabled auto-merge (squash) April 27, 2022 10:29
@andytson-inviqa
Copy link
Contributor

there's a codesniff issue on the change:

> APPLICATION_ENV=development vendor/bin/console code:sniff:style
Store: DE | Environment: development
Run Code Style Sniffer for PROJECT
FILE: /app/src/Pyz/Zed/Queue/QueueConfig.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 30 | ERROR | Invalid typehint `list<int>`
----------------------------------------------------------------------
FILE: ...p/.my127ws/application/overlay/src/Pyz/Zed/Queue/QueueConfig.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 30 | ERROR | Invalid typehint `list<int>`
----------------------------------------------------------------------

auto-merge was automatically disabled April 28, 2022 13:04

Head branch was pushed to by a user without write access

Co-authored-by: andytson-inviqa <andytson-inviqa@users.noreply.github.com>
@andytson-inviqa andytson-inviqa merged commit 994466a into inviqa:1.4.x Apr 28, 2022
@Chemaclass Chemaclass deleted the feature/add-signals-for-graceful-worker-shutdown branch April 28, 2022 13:21
@andytson-inviqa andytson-inviqa added this to the 1.4.0 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request harness-spryker Spryker harness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants