Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with spryker jenkins-runner running as root user #690

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

andytson-inviqa
Copy link
Contributor

No description provided.

@andytson-inviqa andytson-inviqa force-pushed the feature/spryker-jenkins-agent-noroot branch from 5d0e270 to 5bd5d91 Compare April 29, 2022 08:34
@andytson-inviqa andytson-inviqa force-pushed the feature/spryker-jenkins-agent-noroot branch from 5bd5d91 to 8501f5d Compare April 29, 2022 08:55
@andytson-inviqa andytson-inviqa marked this pull request as ready for review April 29, 2022 08:57
@andytson-inviqa
Copy link
Contributor Author

andytson-inviqa commented Apr 29, 2022

While su might not forward signals, tini is correctly forwarding to the jenkins-agent-start script and terminating.
Jenkins jobs from spryker appear to be running ok

kierenevans
kierenevans previously approved these changes Apr 29, 2022
@kierenevans kierenevans enabled auto-merge (squash) April 29, 2022 09:02
@andytson-inviqa andytson-inviqa force-pushed the feature/spryker-jenkins-agent-noroot branch from 6a1e6c4 to ed7fa7c Compare April 29, 2022 09:22
@andytson-inviqa andytson-inviqa added bug Something isn't working harness-spryker Spryker harness labels Apr 29, 2022
@kierenevans kierenevans merged commit 128c0b1 into 1.4.x Apr 29, 2022
@kierenevans kierenevans deleted the feature/spryker-jenkins-agent-noroot branch April 29, 2022 10:34
@andytson-inviqa andytson-inviqa added this to the 1.4.0 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working harness-spryker Spryker harness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants