Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use develop version of php compatibility check tool, for 8.0 and 8.1 checks #715

Merged
merged 7 commits into from
Dec 9, 2022

Conversation

kierenevans
Copy link
Contributor

Ref: PHPCompatibility/PHPCompatibility#1312

The last release was in 2019 for php 7.4.

@kierenevans kierenevans marked this pull request as draft June 3, 2022 12:58
@kierenevans kierenevans marked this pull request as ready for review June 8, 2022 12:13
@kierenevans kierenevans added harness-all Changes required to all harness directories enhancement New feature or request labels Jun 8, 2022
@kierenevans kierenevans added this to the 1.5.0 milestone Jun 8, 2022
"platform": {
"php": "{{ (version_compare(@('akeneo.major_version'), '5', '>=')) ? '7.4' : '7.3.22' }}"
}
},
"minimum-stability": "stable"
"minimum-stability": "alpha",
Copy link
Contributor

@andytson-inviqa andytson-inviqa Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you need alpha packages, put the @alpha on the package, don't allow all packages to be alpha

Copy link
Contributor

@andytson-inviqa andytson-inviqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimum-stability should remain stable

@kierenevans kierenevans force-pushed the use-develop-version-of-php-compatibility-check branch from 8183c7f to 8252fe5 Compare October 30, 2022 04:13
@@ -12,7 +12,8 @@
"behat/mink-goutte-driver": "^1.2",
"dmore/behat-chrome-extension": "^1.3",
"dmore/chrome-mink-driver": "^2.7",
"phpcompatibility/php-compatibility": "dev-master",
"phpcompatibility/php-compatibility": "dev-develop@alpha",
"phpcsstandards/phpcsutils": "1.0.0-alpha4",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different package unfortunately :(

andytson-inviqa
andytson-inviqa previously approved these changes Nov 9, 2022
@andytson-inviqa andytson-inviqa force-pushed the use-develop-version-of-php-compatibility-check branch from 29810b0 to b20575b Compare November 9, 2022 09:55
@kierenevans kierenevans enabled auto-merge (squash) November 9, 2022 10:04
@andytson-inviqa andytson-inviqa force-pushed the use-develop-version-of-php-compatibility-check branch from b20575b to 2e706cc Compare December 9, 2022 11:42
andytson-inviqa
andytson-inviqa previously approved these changes Dec 9, 2022
@andytson-inviqa
Copy link
Contributor

andytson-inviqa commented Dec 9, 2022

Root composer.json requires phpcompatibility/php-compatibility dev-develop@alpha, found phpcompatibility/php-compatibility[dev-develop, 10.x-dev (alias of dev-develop)] but it does not match your minimum-stability.

ugh, an evil to solve an lesser evil

I don't get it

(Note that you can also specify stability requirements on a per-package basis using stability flags in the version constraints that you specify in a require block (see [package links](https://getcomposer.org/doc/04-schema.md#package-links) for more details).

https://github.com/inviqa/harness-base-php/blob/1.5.x/src/drupal8/application/skeleton/composer.json.twig#L6
https://github.com/inviqa/harness-base-php/blob/1.5.x/src/drupal8/application/skeleton/composer.json.twig#L57

fine there

@andytson-inviqa
Copy link
Contributor

andytson-inviqa commented Dec 9, 2022

Does it need @alpha for dev-develop? @dev is probably the correct one, but I think is implied automatically

https://github.com/PHPCompatibility/PHPCompatibility/issues/1306

dev-develop implies its own stability?
@andytson-inviqa
Copy link
Contributor

possibly just a magento1 error now:

#11 54.26 Your requirements could not be resolved to an installable set of packages.
#11 54.26 
#11 54.26   Problem 1
#11 54.26     - Root composer.json requires phpcompatibility/php-compatibility dev-develop -> satisfiable by phpcompatibility/php-compatibility[dev-develop].
#11 54.26     - phpcompatibility/php-compatibility dev-develop requires squizlabs/php_codesniffer ^3.7.1 -> found squizlabs/php_codesniffer[3.7.1] but it conflicts with your root composer.json require (3.2.2).
#11 54.26   Problem 2
#11 54.26     - Root composer.json requires phpcsstandards/phpcsutils 1.0.0-alpha4 -> satisfiable by phpcsstandards/phpcsutils[1.0.0-alpha4].
#11 54.26     - phpcsstandards/phpcsutils 1.0.0-alpha4 requires squizlabs/php_codesniffer ^3.7.1 || 4.0.x-dev@dev -> found squizlabs/php_codesniffer[3.7.1] but it conflicts with your root composer.json require (3.2.2).

@kierenevans kierenevans merged commit a7c29c0 into 1.5.x Dec 9, 2022
@kierenevans kierenevans deleted the use-develop-version-of-php-compatibility-check branch December 9, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request harness-all Changes required to all harness directories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants