-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use develop version of php compatibility check tool, for 8.0 and 8.1 checks #715
Use develop version of php compatibility check tool, for 8.0 and 8.1 checks #715
Conversation
"platform": { | ||
"php": "{{ (version_compare(@('akeneo.major_version'), '5', '>=')) ? '7.4' : '7.3.22' }}" | ||
} | ||
}, | ||
"minimum-stability": "stable" | ||
"minimum-stability": "alpha", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you need alpha packages, put the @alpha
on the package, don't allow all packages to be alpha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minimum-stability should remain stable
8183c7f
to
8252fe5
Compare
@@ -12,7 +12,8 @@ | |||
"behat/mink-goutte-driver": "^1.2", | |||
"dmore/behat-chrome-extension": "^1.3", | |||
"dmore/chrome-mink-driver": "^2.7", | |||
"phpcompatibility/php-compatibility": "dev-master", | |||
"phpcompatibility/php-compatibility": "dev-develop@alpha", | |||
"phpcsstandards/phpcsutils": "1.0.0-alpha4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://packagist.org/packages/phpcsstandards/phpcsdevtools#1.0.0 there's a release out now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different package unfortunately :(
29810b0
to
b20575b
Compare
b20575b
to
2e706cc
Compare
ugh, an evil to solve an lesser evil I don't get it
https://github.com/inviqa/harness-base-php/blob/1.5.x/src/drupal8/application/skeleton/composer.json.twig#L6 fine there |
Does it need
|
dev-develop implies its own stability?
possibly just a magento1 error now:
|
Ref: PHPCompatibility/PHPCompatibility#1312
The last release was in 2019 for php 7.4.