Allow configuring redis options #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kierenevans
commented
Oct 30, 2022
kierenevans
commented
- Upgrade to Redis 6.2+
- Match memory request in kubernetes to one that will work out of the box (the alternative is decreasing maxmemory to fit in the memory request, which will require action to be taken to delete keys)
- Remove the "preview" environment override for memory request as if the service is enabled with a 1Gi maxmemory, it won't fit in 64Mi
- Turn on activedefrag to better handle small keys
kierenevans
added
enhancement
kierenevans
added
harness-magento1
andytson-inviqa
approved these changes
Nov 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.