Support ssh private key Jenkins credentials for chart publish #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andytson-inviqa
added
enhancement
andytson-inviqa
force-pushed
the
feature/ssh-credential-id
branch
from
2aa28b0 to
97f3bfa
Compare
|
just realised this has a bug where if no publish environment variables, then the credential wont be added. I hate having to wrap all conditions duplicated in the outer if, esp as a 3rd's going to be needed, so will have a think about how to do this without that |
kierenevans
previously approved these changes
Mar 14, 2023
andytson-inviqa
force-pushed
the
feature/ssh-credential-id
branch
from
344a898 to
d394c86
Compare
kierenevans
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.