Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tagged version of busybox #755

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Conversation

kierenevans
Copy link
Contributor

@kierenevans kierenevans commented Mar 21, 2023

Avoid using :latest as it's unpredictable.

Less important due to only using chown from busybox.

@kierenevans kierenevans added harness-php PHP harness harness-akeneo Akeneo harness labels Mar 21, 2023
@kierenevans kierenevans enabled auto-merge (squash) March 21, 2023 19:55
@kierenevans kierenevans added the enhancement New feature or request label Mar 22, 2023
@@ -29,7 +29,7 @@ spec:
{{- if not (eq "" (include "application.volumes.wwwDataPaths" $)) }}
initContainers:
- name: cron-volume-permissions
image: busybox
image: busybox:1.36
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be configurable if not latest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.35/1.36 are marked "unstable" as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will sort 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erm, sorry as mentioned 1.35 also "unstable". 1.34 seems the most recent "stable"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.35 is the earliest supported tag on https://hub.docker.com/_/busybox

@kierenevans
Copy link
Contributor Author

Build failed, will take a look

@kierenevans kierenevans merged commit 73f7318 into 1.5.x Mar 24, 2023
@kierenevans kierenevans deleted the use-tagged-version-of-busybox branch March 24, 2023 10:20
@andytson-inviqa andytson-inviqa added this to the 1.5.0 milestone May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request harness-akeneo Akeneo harness harness-php PHP harness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants