Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default tideways application service name is now 'app' #762

Merged
merged 1 commit into from
Mar 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions UPGRADE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ In addition to the README's [Harness Upgrade Instructions], please note these sp

## Upgrading from 1.4.x to 1.5.x

### Drupal Writable Directories

The drupal harness no longer sets /app/config, /app/docroot/modules and /app/docroot/profiles to be web-writable at runtime.

This means that modules cannot be installed via the admin interface unless you are running in the development environment.
Expand All @@ -22,6 +24,17 @@ attribute('app.web_writable_files'):
- '/app/docroot/modules/MODULE_NAME/path/to/file.png
```

### Tideways default application

The default service name for new tideways applications has changed from "web" to "app".

The php.ini configuration for tideways been adjusted to reflect this to avoid confusion with new applications.

To use the old service name "web", set this attribute in your workspace.yml:
```yaml
attribute('php.ext-tideways.config.service'): web
```

## Upgrading from 1.4.0 to 1.4.1

An unintentional helm service key name `resources.cpu.requests` has dropped it's plurality to `resources.cpu.request` to match some existing implementations.
Expand Down
2 changes: 1 addition & 1 deletion src/_base/harness/attributes/common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ attributes.default:
connection: "tcp://tideways:9135"
collect: tracing
sample_rate: 25
service: web
service: app
ext-xdebug:
version: "= (version_compare(@('php.version'), '8.0', '>=') ? '3' : '2')"
enable: false
Expand Down