Fix support for compose v2 in drupal test-unit command #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andytson-inviqa
added
bug
|
tested with compose v2 in #742 |
andytson-inviqa
force-pushed
the
feature/drupal-compose-v2
branch
from
49a0081 to
aafc3e6
Compare
|
it's disappointing how complex this test-unit command is. Ideally it should be simple to allow running fast in repetition. |
|
It's related to the usage of simpletest, which requires files generated by simpletest (via the phpunit command) in docroot/sites/simpletest/ to be available in the php-fpm container. That plus the lack of development dependencies having been installed into the php-fpm container. In the development environment this is a mountpoint shared between both, but in the pipeline it's more tricky. Perhaps we simply share a volume between them in the pipeline instead? |
kierenevans
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.