Update compose ps command to show container hash for DC v2.14 #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to avoid the first build error by updating I assume we need to merge this first to get a green build: #744 |
Yes unless Spryker tests are skipped. |
andytson-inviqa
changed the base branch from
1.5.x
to
feature/phpcsutils-version-fix
andytson-inviqa
added
harness-magento1
andytson-inviqa
force-pushed
the
feature/fix-build-check-for-dc2
branch
from
73b68cb to
42c50d3
Compare
andytson-inviqa
approved these changes
Apr 28, 2023
| @@ -77,7 +77,7 @@ dynamic_console() | |||
| { | |||
| if console_enabled; then | |||
| # ensure it is started | |||
| if [ -z "$("${COMPOSE_BIN[@]}" ps --quiet console)" ]; then | |||
| if [ -z "$("${COMPOSE_BIN[@]}" ps --quiet --all console)" ]; then | |||
There was a problem hiding this comment.
erm, not actually relevant here as its not started if it's not started, but as it's only reproducing same behaviour as before, there's no new bug
andytson-inviqa
changed the title
andytson-inviqa
changed the title
andytson-inviqa
added a commit
to inviqa/harness-docker
that referenced
this pull request
Jun 8, 2023
* inviqa/harness-base-php#727 * inviqa/harness-base-php#760 * inviqa/harness-base-php#752 * inviqa/harness-base-php#717 * inviqa/harness-base-php#777 * inviqa/harness-base-php#686 * inviqa/harness-base-php#713 * inviqa/harness-base-php#770 * inviqa/harness-base-php#759 * inviqa/harness-base-php#707 - except v2 rather than v1
andytson-inviqa
added a commit
to inviqa/harness-docker
that referenced
this pull request
Jun 8, 2023
* inviqa/harness-base-php#727 * inviqa/harness-base-php#760 * inviqa/harness-base-php#752 * inviqa/harness-base-php#717 * inviqa/harness-base-php#777 * inviqa/harness-base-php#686 * inviqa/harness-base-php#713 * inviqa/harness-base-php#770 * inviqa/harness-base-php#759 * inviqa/harness-base-php#707 - except v2 rather than v1
andytson-inviqa
added a commit
to inviqa/harness-docker
that referenced
this pull request
Jun 8, 2023
* inviqa/harness-base-php#727 * inviqa/harness-base-php#760 * inviqa/harness-base-php#752 * inviqa/harness-base-php#717 * inviqa/harness-base-php#777 * inviqa/harness-base-php#686 * inviqa/harness-base-php#713 * inviqa/harness-base-php#770 * inviqa/harness-base-php#759 * inviqa/harness-base-php#707 - except v2 rather than v1
andytson-inviqa
added a commit
to inviqa/harness-docker
that referenced
this pull request
Jun 8, 2023
* inviqa/harness-base-php#727 * inviqa/harness-base-php#760 * inviqa/harness-base-php#752 * inviqa/harness-base-php#717 * inviqa/harness-base-php#777 * inviqa/harness-base-php#686 * inviqa/harness-base-php#713 * inviqa/harness-base-php#770 * inviqa/harness-base-php#759 * inviqa/harness-base-php#707 - except v2 rather than v1
andytson-inviqa
added
harness-all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
It seems that the behaviour of
docker-compose ps --quiethas changed from v2.13 to v2.14 ofdocker-composeIn v1 this command would return the stopped containers, but in v2.14 it only returns the containers if they are running.
The fix is to use the
--allflag. With that the command lists all stopped containers.Changes
--allflag to alldocker-compose pscommands inenable.sh