Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all startup commands convert sidekick run to passthru #785

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

andytson-inviqa
Copy link
Contributor

@andytson-inviqa andytson-inviqa commented Aug 18, 2023

The /tmp/my127ws-std* files created during startup, when on failure, are not available.

Also this is a workaround to the bug in k8s 1.25 app-init/app-migrate not being able to write to these files when root user

The my127 files created on failure during startup are not available.
@andytson-inviqa andytson-inviqa added enhancement New feature or request harness-all Changes required to all harness directories labels Aug 18, 2023
@andytson-inviqa
Copy link
Contributor Author

andytson-inviqa commented Aug 18, 2023

seems to work correctly, drupal9's drush cache:rebuild:

  • docker compose run console app migrate - passthrus
  • ws exec app migrate - runs
  • docker compose run console bash -c 'sleep infinity', then docker exec -it {container name} app migrate - runs
    • this one just to test although SIDEKICK_VERBOSE exported to the init process and sub-processes, exec'ing doesn't get that variable. The default CMD's sleep infinity doesn't get the export as it doesn't need it

@andytson-inviqa andytson-inviqa enabled auto-merge (squash) August 18, 2023 12:08
@andytson-inviqa andytson-inviqa merged commit 7fc9e4e into 1.6.x Aug 18, 2023
@andytson-inviqa andytson-inviqa deleted the feature/sidekick-verbose branch August 18, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request harness-all Changes required to all harness directories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants