Ensure static builds convert sidekick run to passthru #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andytson-inviqa
added
enhancement
kierenevans
previously approved these changes
Aug 18, 2023
|
still is writing to file |
|
turns out it is working, just the ./test uses exec rather than run, and exec intentionally doesn't have |
andytson-inviqa
dismissed
kierenevans’s stale review
The base branch was changed.
So that the logs are available in console on failure, rather than lost, and not embedded as files in the resulting image
andytson-inviqa
force-pushed
the
feature/sidekick-build
branch
from
0c21ec9 to
7f03562
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that the logs are available in console on failure, rather than lost, and not embedded as files in the resulting image