Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use php.ini-production #656

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Use php.ini-production #656

merged 4 commits into from
Nov 27, 2024

Conversation

benbrummer
Copy link
Collaborator

At the moment no php.ini is located at /usr/local/etc/php/php.ini. Based on the documentation https://hub.docker.com/_/php
image
php.ini-production will be used now

@benbrummer
Copy link
Collaborator Author

24d49a4:

  • Sort apt packages and php modules alphabetical
  • Do not install php modules, which are already installed in the base image
  • Install install-php-extensions from github
  • Clean up temporary files from saxon installation
  • use --chmod=0755 in COPY and ADD

535d6d4

  • remove deprecated version
  • remove php.ini mounting again
  • rename image-public to image_public to align volume names

@benbrummer
Copy link
Collaborator Author

6274c43:

@turbo124
Copy link
Member

@benbrummer In the last PR, i did change to mounting the php.ini we provide here:

      - ./php/php.ini:/usr/local/etc/php/php.ini

Would there be any reason to change?

@benbrummer
Copy link
Collaborator Author

@benbrummer In the last PR, i did change to mounting the php.ini we provide here:

      - ./php/php.ini:/usr/local/etc/php/php.ini

Would there be any reason to change?

COPY php/php.ini /usr/local/etc/php/conf.d/app.ini
copies your file already into the image. With the mount in docker-compose.yaml. PDF was not working anywhere for me, no preview + no attachment.

Following the official documentation we should start with php.ini-production
image

and mount - ./php/php.ini:/usr/local/etc/php/conf.d/app.ini we could remove the app.ini from the Dockerfile (or leave it as fallback). The mount is good, as we can change php configuration without rebuilding the entire image.

@turbo124 turbo124 merged commit a6d8f66 into invoiceninja:debian Nov 27, 2024
1 check passed
@turbo124
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants