move client_max_body_size from default.conf to nginx.conf #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…conf (https://nginx.org/en/docs/http/ngx_http_core_module.html#client_max_body_size ) add client_body_buffer_size prevents the following logs: [warn] a client request body is buffered to a temporary file
brdns
changed the title
added 2 commits
November 26, 2024 16:22
Increase allowed memory usage of main container from 512M to 1G This is useful particularly if the server uses a hard drive, which can drastically slow down pdf generation during swap
This reverts commit 3ce5983.
|
Thanks! |
|
@brdns may I ask how big are the files, which you upload? I think about a sufficient configuation for invoiceninja should be nginxclient_max_body_size = 20 php-fpmclient_body_buffer_size = 20M |
|
Hello @benbrummer , I’ve got it set to 10M all around. I’ve kept it at 100M only in the pull request since it was the default value here. You’re probably right, 20M should be enough for most use cases. |
|
@brdns 10M should be a good default. Do you have some recommendation regarding php memory_limit. I have no issues with the default 128M. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client_body_buffer_size[warn] a client request body is buffered to a temporary file