Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php 8.3 and apt package optimization #661

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Conversation

benbrummer
Copy link
Collaborator

@benbrummer benbrummer commented Nov 28, 2024

  • With this pr php will be updated to 8.3
  • memory limits for containers will be removed, as these conflict with php/opcache configuration and cause random 500
  • ap packages for amd64 have been reduced to thge required ones
  • build context has been added to docker compose file, to make it easily deployable with a local build
  • Fix for WARN For [program:scheduler], redirect_stderr=true but stderr_logfile has also been set to a filename, the filename has been ignored

Unchanged behaviour, use latest build from docker hub.

docker compose up

Local build with latest tag

docker compose up --build will build the image with latest tag

Local build with custom tag

export TAG=some_value
docker compose up --build

Get updated base images for the build

docker compose up --pull --build

Benjamin Brummer added 4 commits November 28, 2024 10:22
- Minimal system packages
  - additional packages will be handled as dependencies of google-chrome-stable (amd64
  - arm64 will still install all apt packages
- "--no-install-recommends" for apt-get
@hillelcoren
Copy link
Member

Hey, just wanted to thank you for all of your contributions!

Benjamin Brummer and others added 3 commits November 28, 2024 14:04
… settings

- Overwrite php.ini/php-fpm.ini settings with customized settings
Signed-off-by: benbrummer <info@benjamin-brummer.de>
Signed-off-by: benbrummer <info@benjamin-brummer.de>
@turbo124 turbo124 merged commit baad65c into invoiceninja:debian Nov 28, 2024
1 check passed
@turbo124
Copy link
Member

turbo124 commented Nov 28, 2024

@benbrummer looks good!

@turbo124
Copy link
Member

@benbrummer

We might have to roll this back I am afraid. When i build the image from scratch, i lose access to the mysql client at the command line which is required when running the initial script to write the schema and seed the database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants