-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test -H 1024 -W 1024 fail on MacOS(VENTURA) with NDArray > 2**32 #1244
Comments
Have the same issue, thanks for raising @i3oc9i |
I'm running dev + #1243 w/ 64GB + MacOS Monterrey and I can run it. |
@Any-Winter-4079 , I will try your tomorrow dev + #1234, but I guess that the issue is related to VENTURA |
Can you confirm that you are running VENTURA ? |
Yes latest, only other difference is that I'm on python 3.10 and I have only 32gb :) |
@Vargol if you upgraded to VENTURA can you confirm this issue ? |
I would've sworn it was 2^31 before. I guess there's some metal changes. |
I'm not upgraded yet, I use some software what had known issues with the beta's so not planing to upgrade until its confirmed they now work. |
@i3oc9i @pauloportella In general for a temporary fix, I'd check attention.py and model.py (I think) and simply ensure the tensors are not >2^32 |
Thinking about it, you could do a PR where you check the OS version, and then use a different slice size.
|
Also happens at 64x64. |
I'm still getting this crash. M2 Max MBP running Ventura 13.2. The crash occurs immediately on starting a 1024x1024 generation whether or not --hires-fix is on (if on, the 512x512 pass finishes first). Note that generations larger than 1024x1024 work (at least square generations -- I haven't tried non-square). |
solved with Ventura 13.3 see following comment |
Describe your environment
Describe the bug
I just upgraded my MacOs to Ventura, but I dont know if the issue is related to Ventura because I didnt this test before the upgraded.
NOTE: using --hires_fix the generation start but then I get the same issue
Additional context
test -H960 -W960 is OK
The text was updated successfully, but these errors were encountered: