Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: duplicating regional guidance layers does not provide unique colour #6995

Closed
1 task done
Kelztergit opened this issue Oct 1, 2024 · 5 comments · Fixed by #7015
Closed
1 task done

[bug]: duplicating regional guidance layers does not provide unique colour #6995

Kelztergit opened this issue Oct 1, 2024 · 5 comments · Fixed by #7015
Labels
bug Something isn't working

Comments

@Kelztergit
Copy link

Is there an existing issue for this problem?

  • I have searched the existing issues

Operating system

Windows

GPU vendor

Nvidia (CUDA)

GPU model

4070ti

GPU VRAM

12GB

Version number

5.0.1

Browser

firefox 130.0.1

Python dependencies

No response

What happened

I duplicated a Regional Guidance layer, which duplicated it as expected, However it did not assign it a new colour.

What you expected to happen

I expected it to duplicate it with all the same settings except provide it with a new unique colour.
Currently i am not sure how i am supposed to tell them apart.

How to reproduce the problem

by right clicking on a regional guidance layer and clicking duplicate

Additional context

No response

Discord username

Keldingull

@Kelztergit Kelztergit added the bug Something isn't working label Oct 1, 2024
@psychedelicious
Copy link
Collaborator

You can change the color (and pattern) with this button:
image

@Kelztergit
Copy link
Author

thanks for the reply, But i reported it more so because i thought it was unintended behavior, Is there ever a reason why you would want to have it not get a unique colour? it doesn't function if it has the same colour in my experience, i assumed it'd create a new regional guidance layer and copy only the settings (reference image, weight, method etc)

Further testing with the mask fill changed after the fact it was duplicated with right click duplicate on an existing regional guidance layer shows that this does not resume functionality, Duplicating the layers this way does therefore not only not save time but it also breaks it.
image

Creating a new one and setting it up manually is required.
image

I originally thought the colour itself was used as a unique identifier of sorts but whatever it does behind the scenes is likely being duplicated as well causing it to not be able to continue when two or more exist simultaneously like that.

Therefore this has evolved into technically a new bug "Duplicating regional guidance layers prevents image generation"

@psychedelicious
Copy link
Collaborator

The color is just there to help you - it's not used internally.

I'm not sure I fully understand the issue with generation not working. Can you please clarify what exactly doesn't work, and list the steps I should take to reproduce the issue?

@Kelztergit
Copy link
Author

how to replicate : duplicate a regional guidance layer that has an ip adapter image, i've tried both for sd-1 and sdxl, it doesn't make a difference for this.

error messages : clicking the invoke button causes absolutely nothing to happen, zero errors, it is as if it disables it.

What happens : If a duplicated regional guidance layer using ip adapter exists (regional reference image) and is enabled and you press the invoke button, nothing happens,
You can edit is how you wish, change the image, change the settings, right-click and add a prompt etc, it will not fix it.
You can disable one and regain functionality,
You can create another manually rather than duplicate and it will work, proving it's not an issue with multiple regional guidance ip-adapter using layers.
but it does not work with duplicated ones.

How i found out : Trying to find a quick workflow for myself i thought i'd duplicate a regional guidance layer that used an ip-adapter to maintain the settings, thinking i could just swap out the image and paint up a new area, this ended up not working. I assumed incorrectly that the colour was the issue since it was the most obvious thing that remained the same and theorized it was used for id internally and that borked things up, Later tests revealed it doesn't impact prompt only regional guidance layers so it's specific to ones having ip-adapters /regional reference images.
(i've tested it with text prompts, same colour, and it works even if duplicated)

Theorized cause : Some kind of unique identifier for the ip-adapters gets duplicated along with the rest when it shouldn't perhaps?

@psychedelicious
Copy link
Collaborator

Thanks for the detail. Yes, you are exactly correct, the ref image (ip adapter)'s ID was erroneously duplicated. I've just fixed this.

I think the mask color should not be changed when duplicating the layer. Consider this user flow:

  • I have a regional guidance layer w/ whichever settings.
  • I want to make a variation of it, without losing the original, so I duplicate.
  • I generate w/ the variation and decide I want to go back to the original, so I delete the clone.

In this case, I think we want to leave the mask the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants