-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Update gh actions #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Update gh actions #1118
Changes from 122 commits
Commits
Show all changes
123 commits
Select commit
Hold shift + click to select a range
9ffe113
fix mkdocs deployment
mauwii d748747
update path to python bin
mauwii d86fb2d
add trigger for current branch
mauwii fbe14e3
change path to python_bin for mac as well
mauwii 6b52bbf
try to use setup-python@v4 instead of setting env
mauwii 8ecd0f0
remove setup conda action
mauwii efc74af
try to use $CONDA
mauwii 888b60b
remove overseen action
mauwii e833a43
change branch from master to main
mauwii 8db85b9
sort out if then else for faster syntax
mauwii ae4cffc
remove more if functions
mauwii df51934
add updates to create-caches as well
mauwii 0758cd9
eliminate the rest of if functions
mauwii 6499927
try to unpin pytorch and torchvision
mauwii 3c2ddee
restore pinned versions
mauwii 8c75fcd
try switching from set-output to use env
mauwii 0427383
update test-invoke-conda as well
mauwii 4ea583d
fix env var creation
mauwii 984d7c0
quote variable
mauwii 43cd537
add second equal to compare
mauwii f7c2443
try another way to use outputs
mauwii e2ef595
fix outputs
mauwii 4a6e018
pip install for mac before creating conda env
mauwii f238750
fix output variable
mauwii efdccbf
fix python bin path
mauwii e7d0c40
remove pip install for before creating conda env
mauwii cd21035
unpin streamlit version in conda mac env
mauwii 51ff937
try to make git-workflows better readable
mauwii b353e34
remove 4gotten trigger
mauwii 2c83de9
Update-gh-actions (#6)
mauwii 8a8a952
use macos-latest
mauwii ea07bf1
try to update conda before creating mac env
mauwii 31f33ec
better conda update trial
mauwii 11338c7
re-pin streamlit version
mauwii 2c41bba
re-added trigger to run workflow in current branch
mauwii 0c97db9
try to find out if conda mac env could be updated
mauwii a6e9be9
install cmake, protobuf and rust b4 conda
mauwii 0e3af49
add yes to conda update
mauwii 766c655
lets try anaconda3-2022.05
mauwii a1c30c5
try environment.yml for mac as well
mauwii d09fdb7
reenable conda mac env, add pip install
mauwii 8eedfd8
remove
mauwii 35b810f
remove cmake from brew install since pre-installed
mauwii 580740d
disable opencv-python pip requirement
mauwii c61490c
fixed commands to find latest package versions
mauwii 25c342b
update requirements for mac env
mauwii 6786c26
back to the roots - only install conda env
mauwii 6486fa8
check out macOS in azure-pipelines
mauwii 6367c03
let's try to setup python and update conda env
mauwii 47d6f66
initialize conda before using it
mauwii f8293d6
add trigger in azure-pipelines.yml
mauwii 3dfbc7f
And another go for update first ....
mauwii 979eae6
update azure-pipelines.yml
mauwii 8e7c72f
unquote checkpoint-url
mauwii 242af7e
fix chekpoint-url variable
mauwii ffa0e08
mkdir before downloading model
mauwii 6d734ee
set pr trigger to main, rename anaconda cache
mauwii 79a61d3
Merge branch 'invoke-ai:main' into main
mauwii 394b759
unique cacheHitVariables
mauwii cd0e139
Merge branch 'invoke-ai:main' into update-gh-actions
mauwii 6fc049f
try to use macos-latest instead of macos-12
mauwii 0bbbadb
Merge branch 'invoke-ai:main' into main
mauwii 64dce4e
update test-invoke-conda.yml:
mauwii 8cfff74
Merge branch 'main' into update-gh-actions
mauwii 86f63d2
update test-invoke-conda.yml:
mauwii 9b65621
change macos back to 12 since also fails with 11
mauwii b75935f
update condition in run the tests
mauwii 7b9b870
fix path to cache invokeai conda env
mauwii 46f02d5
fix invokeai conda env cache path
mauwii ec02af7
update mkdocs-flow.yml
mauwii 96ac74e
change conda-channel priority
mauwii 8de7cb3
update create-caches
mauwii 4943e91
update conda env also when cache was used
mauwii 7cca59d
os dependend conda env cache path
mauwii d9a1caa
use existing CONDA env pointing to conda root
mauwii fc56e33
create CONDA_ROOT output from $CONDA
mauwii 1f66f3e
use output variable to define test prompts
mauwii 1a195e2
use setup-python v4, get rid of PYTHON_BIN env
mauwii e60f440
add runner.os to result artifacts name
mauwii 495f0af
update test-invoke-conda.yml:
mauwii 6c49d89
improve mkdocs-flow.yml
mauwii a48d5d5
disable cache-hugginface-torch
mauwii 6a06e04
update mkdocs-flow.yml with new name
mauwii 6168deb
rename mkdocs action to mkdocs-material
mauwii e995213
try to ignore error when creating conda env
mauwii 27e5bfe
remove bloat
mauwii f04fd52
update environment-mac.yml
mauwii fcf7119
disable conda update, tweak prompt condition
mauwii b2b6f8c
try to set some env vars for macOS to fix conda
mauwii 30c2df5
stop ignoring error, use env instead of outputs
mauwii 41bcdff
tweak `[[` connditions
mauwii 8688fcb
update python and pip dependencie
mauwii 3a64623
remove unecesarry env for macOS
mauwii 2501998
update conda env in setup step
mauwii f22a622
activate conda env after installation
mauwii 2d39da3
update test-invoke-conda.yml
mauwii 2d93382
fix activate conda env
mauwii 2b7f426
set bash -l as default shell
mauwii 4e0955e
use action to activate conda env
mauwii 07588eb
add conda env file to env activation
mauwii a97bdc7
try to replace s-weigeand with conda-incubator
mauwii 9d1af6e
remove azure-pipelines.yml
mauwii 8383e44
include environment-file in matrix
mauwii c46ba28
fix miniforge-variant, set fail-fast to false
mauwii 393a87b
add step to setup miniconda
mauwii 4adb165
Merge branch 'invoke-ai:main' into main
mauwii 3a5670b
Merge remote-tracking branch 'origin/main' into update-gh-actions
mauwii af4f72c
use a mac env yml without pinned versions
mauwii 431ea7a
unpin nomkl, pytorch and torchvision
mauwii e66efd1
cache conda pkgs dir instead of conda env
mauwii 8fac90d
use python 3.10, exclude macos-12 from cache
mauwii fec9f26
fix expression
mauwii b95886f
prepare for PR
mauwii 4192ca0
fix doubled id
mauwii 2e31ad4
reuse pinned versions in mac conda env
mauwii f079019
fix classical copy/paste error
mauwii 58636bf
remove unused env from shell-block comment
mauwii 65c6eea
fix hashFiles function to determine restore-keys
mauwii 7d53d11
reenable caching `~.cache`, update create-caches
mauwii 8bd8eac
unpin all versions in mac conda env file
mauwii c141df6
prepare merge by removing this branch from trigger
mauwii 3fd2efc
include pull_request trigger for main and dev
mauwii 8041e4f
remove pull_request trigger
mauwii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| name: mkdocs-material | ||
| on: | ||
| push: | ||
| branches: | ||
| - 'main' | ||
| - 'development' | ||
| pull_request: | ||
| branches: | ||
| - 'main' | ||
| - 'development' | ||
|
|
||
| jobs: | ||
| mkdocs-material: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: checkout sources | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: setup python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '3.10' | ||
|
|
||
| - name: install requirements | ||
| run: | | ||
| python -m \ | ||
| pip install -r requirements-mkdocs.txt | ||
|
|
||
| - name: confirm buildability | ||
| run: | | ||
| python -m \ | ||
| mkdocs build \ | ||
| --clean \ | ||
| --verbose | ||
|
|
||
| - name: deploy to gh-pages | ||
| if: ${{ github.ref == 'refs/heads/main' }} | ||
| run: | | ||
| python -m \ | ||
| mkdocs gh-deploy \ | ||
| --clean \ | ||
| --force |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During my (unfortunately very lengthy and time-consuming 🙄) testing when I was trying to get Windows working, without success, I noticed that on average it's much faster to download the model every time because when you stash something in the lookaside cache to reuse, it gets zipped.
So instead of a straightforward download from Hugging Face's servers, there's a much more complicated download/unzip/move/not sure what else which usually takes longer (and yeah, this is across all three platforms).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest - I didn't find out how I need to create the secret with a token in a way that it is valid as long as the token - I cheated on my side with this secret (while still obtaining it from the huggingface site), but this was about 50% the speed I get from downloading it out of the cache (and the cache would still be valid after the secret has already lost it's authorization 🙈)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I forgot about that - I had to set up my token for it to work properly. The main repo should never have this issue, and if it does, it's something which we'd need to fix immediately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should I disable the caching and always download, r u sure? imho this can be rly helpfull when there are many runs and saves bandwith of the backbone for people watching cat videos on YT ;P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I'm saying - it isn't. I was absolutely stunned by this at first, so I went down a total rabbithole of stopping work on getting Windows working just to focus on the model download.
ON AVERAGE, downloading the model is faster (by a lot) than caching it.
OTOH, "saves bandwith of the backbone" is another reason why we want to limit the number of times we run the suite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for me the download from huggingface usually had betwen 50-100MB/s while GH-Cache had about 150MB/s, which is also handled internally and not over the web (where I am not sure if downloading from huggingface is maybe slower because it needs to be routed externally), which would lead to --> using cache doesn't bother the backend at all ;P