feat: Unify Promp Area Styling #4033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blessedcoolant
requested review from
maryhipp and
psychedelicious
as code owners
psychedelicious
suggested changes
Jul 27, 2023
Contributor
psychedelicious
left a comment
psychedelicious
left a comment
There was a problem hiding this comment.
The concat toggle switch is in a really crowded space, and the box around the prompts adds more visual noise to the UI hierarchy.
I'd rather add a small link icon to the style prompt boxes that acts a toggle for concat prompt - like the TI button. It should be accent colored when enabled so you can't miss it.
This make this additional feature visually minimal and keeps with our established prompt UI/UX, and is just as functional. Then there's no need for an extra box around the prompts
I'm undecided on whether or not it should be independent for positive & negative or linked
invokeai/frontend/web/src/features/controlNet/components/parameters/ParamControlNetModel.tsx
Outdated
Show resolved
Hide resolved
`ControlNetModelConfig` was split into `ControlNetModelCheckpointConfig` and `ControlNetModelDiffusersConfig`, need to update the UI types
This reverts commit f057d5c.
Might remove the lines. Just pushing to save changes for now.
- make the `SDXLConcatLink` icon match existing colors in light mode - make the link toggle button accent color when active (its not super obvious but at least there is *some* visual difference for the button)
psychedelicious
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
Making the prompt area styling match across all tabs / models and move all prompt related components into a parent components for quick add.
Cherry picked stuff from the Styles PR coz we ain't gonna merge that.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?