Feat/auto assign board on click #4086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBrack
requested review from
blessedcoolant,
maryhipp and
psychedelicious
as code owners
1 task
psychedelicious
suggested changes
Jul 31, 2023
Contributor
psychedelicious
left a comment
psychedelicious
left a comment
There was a problem hiding this comment.
Thanks! Requesting 3 changes - 2 in the code comments, the other here:
There's a Board context menu that currently has an option to set the auto-add board (see invokeai/frontend/web/src/features/gallery/components/Boards/BoardContextMenu.tsx)
If you want to prevent changing the auto-add board during processing or when assign-on-click is enabled, that menu item would need to be marked disabled also.
invokeai/frontend/web/src/features/gallery/components/GallerySettingsPopover.tsx
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/gallery/components/Boards/BoardsList/NoBoardBoard.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I believe all requirements have been met now |
psychedelicious
approved these changes
Aug 2, 2023
Contributor
psychedelicious
left a comment
psychedelicious
left a comment
There was a problem hiding this comment.
Thanks @KevinBrack !
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
Add feature auto assign board on click. There is a new setting in the board menu. It is checked by default. When checked the auto assign board is changed whenever selecting a board. The auto assign board will not change during image generation. If the new feature is disabled in the settings the original method of assigning a board returns.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Open the board menu by clicking the dropdown with the selected board. Click the settings icon. Note that the new option Auto-Assign Board on Click is selected. When this option is enabled the auto assign board switches by changing the active board. When Auto-Assign Board on Click is not selected you get a dropdown to assign the active board. The board assignment should not change during image generation.
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
No