fix(db): retrieve metadata even when no session_id #4110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
Kyle0654,
blessedcoolant,
brandonrising and
maryhipp
as code owners
maryhipp
approved these changes
Aug 1, 2023
Contributor
maryhipp
left a comment
maryhipp
left a comment
There was a problem hiding this comment.
The metadata change looks good to me - not sure about the onnx stuff
this was unnecessarily skipped if there was no `session_id`.
psychedelicious
force-pushed
the
fix/db/metadata-no-session
branch
from
957e551 to
9a8b1c6
Compare
Contributor
Author
|
@maryhipp Sorry I had based this on a diff branch, fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
Note: this PR is based on #4105
fix(db): retrieve metadata even when no session_id
this was unnecessarily skipped if there was no
session_id.Related Tickets & Documents
https://discord.com/channels/1020123559063990373/1134237957381947563/1135810973446439033
QA Instructions, Screenshots, Recordings
Metadata should load for images without a session. This is a fix for @techjedi's import script (on discord).
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
nah