Fix hue adjustment #4182
Merged
Fix hue adjustment #4182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hue adjustment wasn't working correctly because color channels got swapped. This has now been fixed.
JPPhoto
requested review from
Kyle0654,
blessedcoolant,
brandonrising and
psychedelicious
as code owners
Contributor
Author
|
This PR also changes the values from 0..180 to the typical 0..360 that image editing programs use. |
psychedelicious
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hue adjustment wasn't working correctly because color channels got swapped. This has now been fixed.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
The image resulting from a hue shift had discontinuities in color. This was a result of color channels being swapped prior to the conversion to/from HSV. This PR fixes the problem.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?