Fix crash when attempting to update a model #4192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstein
requested review from
GreggHelt2,
StAlKeR7779,
blessedcoolant,
brandonrising and
damian0815
as code owners
keturn
approved these changes
Aug 7, 2023
3 tasks
psychedelicious
approved these changes
Aug 8, 2023
Contributor
psychedelicious
left a comment
psychedelicious
left a comment
There was a problem hiding this comment.
Thanks and sorry for this bug! I implemented the ~same fix in #4195 before realizing you already PR'd a fix. I've closed my PR.
Collaborator
Author
Hey, I'm so grateful to you for fixing all the typing errors! |
StAlKeR7779
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
A logic bug was introduced in PR #4109 that caused Web-based model updates to fail with a pydantic validation error. This corrects the problem.
Related Tickets & Documents
PR #4109