Remove fastapi-socketio dependency, doesn't really do much for us and… #4552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonrising
requested review from
Kyle0654,
blessedcoolant,
hipsterusername,
lstein and
psychedelicious
as code owners
Contributor
Author
|
For reference on what this dependency was doing for us and how much it's being maintained |
Contributor
Author
|
This pip module reminds me of this https://qz.com/646467/how-one-programmer-broke-the-internet-by-deleting-a-tiny-piece-of-code |
Member
|
Wow, talk about middle-man. |
psychedelicious
approved these changes
Sep 18, 2023
Contributor
psychedelicious
left a comment
psychedelicious
left a comment
There was a problem hiding this comment.
Nice, tested working. Even better IDE hints with this, and I'm glad we've moved to using the standard ASGI convention.
blessedcoolant
approved these changes
Sep 20, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… isn't well maintained
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?