feat(nodes): Center pasted nodes at mouse location #4595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrypticWit
requested review from
blessedcoolant,
hipsterusername,
maryhipp and
psychedelicious
as code owners
CrypticWit
changed the title
psychedelicious
approved these changes
Sep 21, 2023
Contributor
psychedelicious
left a comment
psychedelicious
left a comment
There was a problem hiding this comment.
Thanks! As mentioned on discord, I've implemented my requested changes and added context for each to the PR.
invokeai/frontend/web/src/features/nodes/components/flow/Flow.tsx
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/nodes/components/flow/Flow.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
Updated the node copy/paste behaviour so that the newly pasted nodes are created where the mouse is pointing. When there are multiple nodes being pasted, they'll be positioned so the mouse is in the center (by average) of the pasted nodes. I've found this makes the process of copying and pasting nodes a lot more user-friendly, particularly with larger workflows.
I haven't written any sort of React before, so I am not sure if my way of implementing retrieving and tracking mouse position is correct, or if there is a better way of implementing it. Happy to make whatever sort of updates are required if the way I've done it needs rewriting.