Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image tiling nodes to enable Tiled Upscaling #5142

Merged
merged 16 commits into from
Nov 30, 2023
Merged

Add image tiling nodes to enable Tiled Upscaling #5142

merged 16 commits into from
Nov 30, 2023

Commits on Nov 30, 2023

  1. Add nodes for tile splitting and merging. The main motivation for the… 

    …se nodes is for use in tiled upscaling workflows.
    @RyanJDick @hipsterusername
    RyanJDick authored and hipsterusername committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    9da7888 View commit details
    Browse the repository at this point in the history

  2. Add unit tests for tile paste(...) util function.

    @RyanJDick @hipsterusername
    RyanJDick authored and hipsterusername committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    3fd882d View commit details
    Browse the repository at this point in the history

  3. Add unit tests for calc_tiles_with_overlap(...) and fix a bug in its … 

    …implementation.
    @RyanJDick @hipsterusername
    RyanJDick authored and hipsterusername committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    6c959f0 View commit details
    Browse the repository at this point in the history

  4. Add unit tests for merge_tiles_with_linear_blending(...).

    @RyanJDick @hipsterusername
    RyanJDick authored and hipsterusername committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    0277815 View commit details
    Browse the repository at this point in the history

  5. Tidy up tiles invocations, add documentation.

    @RyanJDick @hipsterusername
    RyanJDick authored and hipsterusername committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    078b8eb View commit details
    Browse the repository at this point in the history

  6. (minor) Add 'Invocation' suffix to all tiling node classes.

    @RyanJDick @hipsterusername
    RyanJDick authored and hipsterusername committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    7a0cc75 View commit details
    Browse the repository at this point in the history

  7. Copy CropLatentsInvocation from https://github.com/skunkworxdark/XYGr… 

    …id_nodes/blob/74647fa9c1fa57d317a94bd43ca689af7f0aae5e/images_to_grids.py#L1117C1-L1167C80.
    @RyanJDick @hipsterusername
    RyanJDick authored and hipsterusername committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    281e8e9 View commit details
    Browse the repository at this point in the history

  8. Use LATENT_SCALE_FACTOR = 8 constant in CropLatentsInvocation.

    @RyanJDick @hipsterusername
    RyanJDick authored and hipsterusername committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    ef52b4b View commit details
    Browse the repository at this point in the history

  9. Improve documentation of CropLatentsInvocation.

    @RyanJDick @hipsterusername
    RyanJDick authored and hipsterusername committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    d757f68 View commit details
    Browse the repository at this point in the history

  10. Rename CropLatentsInvocation -> CropLatentsCoreInvocation to prevent … 

    …conflict with custom node. And other minor tidying.
    @RyanJDick @hipsterusername
    RyanJDick authored and hipsterusername committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    27a67ae View commit details
    Browse the repository at this point in the history

  11. Update tiling nodes to use width-before-height field ordering convent… 

    …ion.
    @RyanJDick @hipsterusername
    RyanJDick authored and hipsterusername committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    8dd5354 View commit details
    Browse the repository at this point in the history

  12. Add width and height fields to TileToPropertiesInvocation output to a… 

    …void having to calculate them with math nodes.
    @RyanJDick @hipsterusername
    RyanJDick authored and hipsterusername committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    ce0b0af View commit details
    Browse the repository at this point in the history

  13. Infer a tight-fitting output image size from the passed tiles in Merg… 

    …eTilesToImageInvocation.
    @RyanJDick @hipsterusername
    RyanJDick authored and hipsterusername committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    fee53fc View commit details
    Browse the repository at this point in the history

  14. Re-organize merge_tiles_with_linear_blending(...) to merge rows horiz… 

    …ontally first and then vertically. This change achieves slightly more natural blending on the corners where 4 tiles overlap.
    @RyanJDick @hipsterusername
    RyanJDick authored and hipsterusername committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    9d288e1 View commit details
    Browse the repository at this point in the history

  15. Change input field ordering of CropLatentsCoreInvocation to match Ima… 

    …geCropInvocation.
    @RyanJDick @hipsterusername
    RyanJDick authored and hipsterusername committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    2387825 View commit details
    Browse the repository at this point in the history

  16. (minor) Tweak field ordering and field names for tiling nodes.

    @RyanJDick @hipsterusername
    RyanJDick authored and hipsterusername committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    972b854 View commit details
    Browse the repository at this point in the history