Switch ModelSearch from os.walk to os.scandir

[brandonrising]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update
• Community Node Submission

Have you discussed this change with the InvokeAI team?

• Yes
• No, because:

Have you updated all relevant documentation?

• Yes
• No

Description

Drastically speeds up initial invokeai startup time and subsequent model scans

Related Tickets & Documents

• Related Issue #
• Closes #

QA Instructions, Screenshots, Recordings

Merge Plan

Added/updated tests?

• Yes
• No : please replace this line with details on why tests
  have not been included

[optional] Are there any post deployment tasks we need to perform?

[psychedelicious]

This needs cross platform testing. Scandir uses different system APIs for each platform than walk.

Also we should probably manually test the outputs from each method to ensure the behaviour isn't changed.

[blessedcoolant]

This needs cross platform testing. Scandir uses different system APIs for each platform than walk.

Also we should probably manually test the outputs from each method to ensure the behaviour isn't changed.

The only change I think we need to make here is to pass the as_posix value to scandir rather than the Path object because that is where the cross platform issues might pop up. Afaik, scandir itself works well cross platform as long as the supplied path is a string that is absolute.