Next: Remove deprecated app.on_event usage in api runner #5824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonrising
requested review from
blessedcoolant,
psychedelicious and
hipsterusername
as code owners
psychedelicious
force-pushed
the
next-remove-deprecated-events
branch
from
f2a76c2
to
8cbd22b
Compare
psychedelicious
approved these changes
Feb 29, 2024
brandonrising
requested review from
lstein,
GreggHelt2 and
RyanJDick
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
FastAPI is deprecating app.on_event which we currently use as our startup and shutdown hooks. FastAPI recommends replacing it with this lifespan feature.